-
Notifications
You must be signed in to change notification settings - Fork 16
DM-7995: options for lsst #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- filtering the IRSA master table - Zoom to selection - then catalog panel do selection or viewport corners - Options to allow catalog search to come up with polygon when image is selected - option to recenter to selected area - fixed bug: image is not selected when plotted. - Add two new icons
} | ||
else { | ||
const {value:cornerCalcV}= inFields.imageCornerCalc||'user'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.... || 'user' or ... || {value: 'user'} ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, that's wrong
componentWillReceiveProps(nextProps) { | ||
// const fields= FieldGroupUtils.getGroupFields(this.nextProps.groupKey); | ||
const {coneMax, boxMax, groupKey}= nextProps; | ||
if (coneMax && groupKey) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if I understand the logic. should the case 'boxMax&&groupKey' be considered?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be coneMax && boxMax && groupKey
- I will fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found another problem to, I accidentally took out the passing the properties when I was cleaning up.
Review completed. |
That is the behavior. We can always modify it later. Right now if you switch to user, it just means that it will not change it. If you start editing it will switch to user for you. I am not trying to remember the laster user entry. |
is selected