Skip to content

DM-7995: options for lsst #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2016
Merged

DM-7995: options for lsst #211

merged 2 commits into from
Oct 20, 2016

Conversation

robyww
Copy link
Contributor

@robyww robyww commented Oct 19, 2016

  • filtering the IRSA master table
  • Zoom to selection
  • then catalog panel do selection or viewport corners
  • Options to allow catalog search to come up with polygon when image
    is selected
  • option to recenter to selected area
  • fixed bug: image is not selected when plotted.
  • Add two new icons

  - filtering the IRSA master table
  - Zoom to selection
  - then catalog panel do selection or viewport corners
  - Options to allow catalog search to come up with polygon when image
      is selected
  - option to recenter to selected area
  - fixed bug: image is not selected when plotted.
  - Add two new icons
}
else {
const {value:cornerCalcV}= inFields.imageCornerCalc||'user';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.... || 'user' or ... || {value: 'user'} ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, that's wrong

componentWillReceiveProps(nextProps) {
// const fields= FieldGroupUtils.getGroupFields(this.nextProps.groupKey);
const {coneMax, boxMax, groupKey}= nextProps;
if (coneMax && groupKey) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if I understand the logic. should the case 'boxMax&&groupKey' be considered?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be coneMax && boxMax && groupKey - I will fix it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found another problem to, I accidentally took out the passing the properties when I was cleaning up.

@cwang2016
Copy link
Contributor

Review completed.
One question regarding the coordinates for the polygon. In 'catalogs' panel, I copy & paste the coordinates from example. and enter 'search', then come back to the 'catalogs' panel, and switch the radio button for 'Corners' from 'User' to 'ViewPort' and then back to 'User', the coordinate string is not shown as the original string for 'User' but as the string for 'ViewPort'. Is that as expected?

@robyww
Copy link
Contributor Author

robyww commented Oct 20, 2016

That is the behavior. We can always modify it later. Right now if you switch to user, it just means that it will not change it. If you start editing it will switch to user for you. I am not trying to remember the laster user entry.

@robyww robyww merged commit 74504da into dev Oct 20, 2016
@robyww robyww deleted the dm-7995-lsst-ops branch October 20, 2016 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants